Comments on: JavaScript Query String http://prettycode.org/2009/04/21/javascript-query-string/ foreach(bill) paywith(skill); Fri, 05 Mar 2010 01:42:16 +0000 http://wordpress.org/?v=2.9.2 hourly 1 By: Chris http://prettycode.org/2009/04/21/javascript-query-string/comment-page-1/#comment-12 Chris Fri, 24 Apr 2009 17:54:38 +0000 http://prettycode.org/?p=145#comment-12 @Miron: I don't think the GetQuerystringParam() you've shown is a bad tool. My concern with using it is that it's easily abused <i>because it's a function</i>. What if another developer is maintaining the app. and wants to grab another value in the query string? They'll likely just call the same function you used. The consequence isn't performance (as you say, it's negligible). Code should be written with reuse in mind, and defensively against misuse—as a practice. A function encourages repetitious, procedural, imperative design, while an object encourages encapsulation, separation of concerns, and adherence to DRY. The consequence (at least in my mind) is that such a function has greater potential to encourage sloppy code. I think what is probably a great idea is replacing the name/value parsing logic in my code with the regular expressions you're using if the regex is bulletproof. :) @Miron: I don’t think the GetQuerystringParam() you’ve shown is a bad tool. My concern with using it is that it’s easily abused because it’s a function. What if another developer is maintaining the app. and wants to grab another value in the query string? They’ll likely just call the same function you used. The consequence isn’t performance (as you say, it’s negligible). Code should be written with reuse in mind, and defensively against misuse—as a practice. A function encourages repetitious, procedural, imperative design, while an object encourages encapsulation, separation of concerns, and adherence to DRY. The consequence (at least in my mind) is that such a function has greater potential to encourage sloppy code.

I think what is probably a great idea is replacing the name/value parsing logic in my code with the regular expressions you’re using if the regex is bulletproof. :)

]]> By: Miron http://prettycode.org/2009/04/21/javascript-query-string/comment-page-1/#comment-11 Miron Fri, 24 Apr 2009 09:54:30 +0000 http://prettycode.org/?p=145#comment-11 In other hand, why should you parse all the query string parameters when you need only one? Also, you are talking about client side code and regular expression over not so long string... The performance impact is negligible. In other hand, why should you parse all the query string parameters when you need only one?
Also, you are talking about client side code and regular expression over not so long string… The performance impact is negligible.

]]> By: Chris http://prettycode.org/2009/04/21/javascript-query-string/comment-page-1/#comment-10 Chris Thu, 23 Apr 2009 03:38:01 +0000 http://prettycode.org/?p=145#comment-10 @Garry: Good point. In response, I've changed the script to avoid manually rebuilding the decoded query string toString() returns, and instead, the decoded <c>location.search</c> value is returned by toString(). Thanks again! @Garry: Good point. In response, I’ve changed the script to avoid manually rebuilding the decoded query string toString() returns, and instead, the decoded location.search value is returned by toString(). Thanks again!

]]> By: Chris http://prettycode.org/2009/04/21/javascript-query-string/comment-page-1/#comment-9 Chris Thu, 23 Apr 2009 03:34:53 +0000 http://prettycode.org/?p=145#comment-9 @Miron: While that works, every time GetQuerystringParam() is invoked, the URL has mutiple regular expressions matched against it, which is bad practice. The URL should be broken down into a collection or examined for a name/value pair <i>once</i>; not every time a query string parameter value is needed. @Miron: While that works, every time GetQuerystringParam() is invoked, the URL has mutiple regular expressions matched against it, which is bad practice. The URL should be broken down into a collection or examined for a name/value pair once; not every time a query string parameter value is needed.

]]> By: Miron http://prettycode.org/2009/04/21/javascript-query-string/comment-page-1/#comment-8 Miron Wed, 22 Apr 2009 19:57:18 +0000 http://prettycode.org/?p=145#comment-8 You can use this method: <pre lang="javascript"> // // Get query string parameter // function GetQuerystringParam(name, url) { name = name.replace(/[\[]/, "\\\[").replace(/[\]]/, "\\\]"); var regexS = "[\\?&]" + name + "=([^&#]*)"; var regex = new RegExp(regexS); if (typeof (url) == 'undefined') url = window.location.href; var results = regex.exec(url); if (results == null) return ""; else return results[1]; } </pre> You can use this method:

//
// Get query string parameter
//
function GetQuerystringParam(name, url) {
    name = name.replace(/[\[]/, "\\\[").replace(/[\]]/, "\\\]");
    var regexS = "[\\?&amp;]" + name + "=([^&amp;#]*)";
    var regex = new RegExp(regexS);
    if (typeof (url) == 'undefined') url = window.location.href;
    var results = regex.exec(url);
    if (results == null)
        return "";
    else
        return results[1];
}
]]> By: WebDevVote.com http://prettycode.org/2009/04/21/javascript-query-string/comment-page-1/#comment-7 WebDevVote.com Wed, 22 Apr 2009 16:39:58 +0000 http://prettycode.org/?p=145#comment-7 You are voted! Track back from http://webdevvote.com You are voted!
Track back from http://webdevvote.com

]]> By: Garry Shutler http://prettycode.org/2009/04/21/javascript-query-string/comment-page-1/#comment-6 Garry Shutler Wed, 22 Apr 2009 14:00:32 +0000 http://prettycode.org/?p=145#comment-6 Why no make toString just return window.location.search? Saves encoding what you just decoded. Why no make toString just return window.location.search? Saves encoding what you just decoded.

]]>